| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Make pg_stat_io view count IOs as bytes instead of blocks |
| Date: | 2025-01-16 05:13:08 |
| Message-ID: | Z4iVZHJp_Go8lcbz@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 15, 2025 at 11:34:14PM -0500, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > I cannot reproduce that, perhaps I'm just missing something with these
> > switches. Do you think that a cast would cool things? Please see the
> > attached for the idea.
>
> There are only three animals showing this warning (ayu, batfish,
> demoiselle) so it likely requires particular clang versions
> as well as the right -W switches.
All of them on ppc with clang 4 or 5. That's dated. :)
> Maybe a cast would silence it, but your draft seems
> underparenthesized. (Which raises the question of whether we
> should be using a macro for this at all --- probably there's
> not much risk of double-evaluation being a problem, but a
> static inline would remove the risk.)
Just for an assert, I would just remove the macro rather than have an
inline function.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgstat_io_warning_v2.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Khanna | 2025-01-16 05:17:39 | Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size |
| Previous Message | Amit Kapila | 2025-01-16 05:06:27 | Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING |