| From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size |
| Date: | 2025-01-16 05:17:39 |
| Message-ID: | CAHv8RjJ59afLCoGHnp9=N8qq6UqpAYVBinGnaQMfBcbZFJQYKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 15, 2025 at 3:28 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Shubham.
>
> Patch v9-0001 LGTM.
>
Upon reviewing the v9-0001 patch, I noticed that running 'pg perltidy'
was necessary. To ensure the patch adheres to the required coding
standards, I have applied 'pg perltidy' and made the necessary
adjustments.
The attached patch includes these formatting fixes along with the
latest changes.
Thanks and regards,
Shubham Khanna.
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Validate-max_slot_wal_keep_size-in-pg_createsubs.patch | application/octet-stream | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-01-16 05:17:51 | Re: Non-text mode for pg_dumpall |
| Previous Message | Michael Paquier | 2025-01-16 05:13:08 | Re: Make pg_stat_io view count IOs as bytes instead of blocks |