Re: Non-text mode for pg_dumpall

hi.

in master src/bin/pg_dump/pg_restore.c: main function
if (opts->tocSummary)
PrintTOCSummary(AH);
else
{
ProcessArchiveRestoreOptions(AH);
RestoreArchive(AH);
}
opts->tocSummary is true (pg_restore --list), no query will be executed.
but your patch (pg_restore --list) may call execute_global_sql_commands,
which executes a query.

sscanf(line, "%u" , &db_oid);
sscanf(line, "%s" , db_oid_str);
i think it would be better
sscanf(line, "%u %s" , &db_oid, db_oid_str);

in doc/src/sgml/ref/pg_dumpall.sgml
Note: This option can be omitted only when --format=p|plain.
maybe change to
Note: This option can be omitted only when <option>--format</option> is plain.

--format=format section:
""
Under this databases subdirectory, there will be subdirectory with
dboid name for each database.
""
this sentence is not correct? because
drwxr-xr-x databases
.rw-rw-r-- global.dat
.rw-rw-r-- map.dat

"databases" is a directory, and under the "database" directory, it's a
list of files.
each file filename is corresponding to a unique database name
so there is no subdirectory under subdirectory?

in src/bin/pg_dump/meson.build
you need add 'common_dumpall_restore.c', to the pg_dump_common_sources section.
otherwise meson build cannot compile.

$BIN6/pg_restore --dbname=src6 --verbose --list $SRC6/dumpall.custom6
pg_restore: error: option -C/--create should be specified when using
dump of pg_dumpall
this command should not fail?

in doc/src/sgml/ref/pg_restore.sgml
<varlistentry>
...
<term><option>--format=<replaceable
class="parameter">format</replaceable></option></term>
also need
<term><literal>plain</literal></term>
?