Re: Make pg_stat_io view count IOs as bytes instead of blocks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Make pg_stat_io view count IOs as bytes instead of blocks
Date: 2025-01-16 04:34:14
Message-ID: 1541695.1737002054@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> I cannot reproduce that, perhaps I'm just missing something with these
> switches. Do you think that a cast would cool things? Please see the
> attached for the idea.

There are only three animals showing this warning (ayu, batfish,
demoiselle) so it likely requires particular clang versions
as well as the right -W switches.

Maybe a cast would silence it, but your draft seems
underparenthesized. (Which raises the question of whether we
should be using a macro for this at all --- probably there's
not much risk of double-evaluation being a problem, but a
static inline would remove the risk.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhang Mingli 2025-01-16 04:39:06 Inquiry About Determining Parallel Plans for REFRESH MATERIALIZED VIEW
Previous Message Tom Lane 2025-01-16 04:26:50 Re: TOAST versus toast