| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency |
| Date: | 2025-03-25 03:01:52 |
| Message-ID: | OSCPR01MB1496623BE1125B44614494E7AF5A72@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear hackers,
While reading the code, I found $SUBJECT. It says:
```
/*
* Publication relation/schema map syscache invalidation callback
*
* Called for invalidations on pg_publication and pg_namespace.
*/
static void
rel_sync_cache_publication_cb(Datum arg, int cacheid, uint32 hashvalue)
```
But this won't be called for invalidating pg_publication. It should have been
updated by 3abe9dc1, but it was an oversight.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pgoutput-Update-code-comment.patch | application/octet-stream | 932 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-03-25 03:18:00 | RE: Improve error reporting for few options in pg_createsubscriber |
| Previous Message | Tom Lane | 2025-03-25 02:56:30 | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |