| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> | 
|---|---|
| To: | 'vignesh C' <vignesh21(at)gmail(dot)com> | 
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> | 
| Subject: | RE: Improve error reporting for few options in pg_createsubscriber | 
| Date: | 2025-03-25 03:18:00 | 
| Message-ID: | OSCPR01MB14966484D047CCD6DE2D6E146F5A72@OSCPR01MB14966.jpnprd01.prod.outlook.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Dear Vignesh,
> Currently, error reports for database, publication, subscription, and
> replication slots do not include the option name. This has been
> addressed by including the option name in the error messages, ensuring
> consistency similar to remove option.
Confirmed all error reporting in switch have its option name.
> Additionally, pg_log_error and
> exit(1) have been replaced with a single pg_fatal statement which
> means the same. The attached patch implements these changes.
I grepped source and confirmed that exit(1) just after pg_log_error()
does not exist anymore. Several lines have below style, but IIUC it is
out-of-scope of the patch.
pg_log_error();
pg_log_error_hint();
exit(1);
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2025-03-25 03:21:08 | Re: Conflict detection for multiple_unique_conflicts in logical replication | 
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-03-25 03:01:52 | pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency |