| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency |
| Date: | 2025-03-25 03:35:54 |
| Message-ID: | CAA4eK1+7-C0ZpTn=A8swmnwN_J4g_BEyYpKXk6iFgz6ZMj_WJw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 25, 2025 at 8:31 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear hackers,
>
> While reading the code, I found $SUBJECT. It says:
>
> ```
> /*
> * Publication relation/schema map syscache invalidation callback
> *
> * Called for invalidations on pg_publication and pg_namespace.
> */
> static void
> rel_sync_cache_publication_cb(Datum arg, int cacheid, uint32 hashvalue)
> ```
>
> But this won't be called for invalidating pg_publication. It should have been
> updated by 3abe9dc1, but it was an oversight.
>
Agreed and thanks for the patch.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-03-25 03:42:53 | Re: Conflict detection for multiple_unique_conflicts in logical replication |
| Previous Message | David Rowley | 2025-03-25 03:32:56 | Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment |