| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, ma lz <ma100(at)hotmail(dot)com> |
| Subject: | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |
| Date: | 2025-03-25 02:56:30 |
| Message-ID: | 1192185.1742871390@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Sami Imseih <samimseih(at)gmail(dot)com> writes:
> I agree that some may want stats to merge for the same tables,
> and others may not. I will suggest this with some hesitation, but why not
> make this behavior configurable via a GUC?
> We recently introduced query_id_squash_values for controlling
> the merge of an IN list, maybe this is another queryId behavior we should
> provide a configuration for?
I don't like that GUC and I would not like this one either. We
learned years ago that GUCs that change query semantics are a bad
idea, but apparently now we have hackers who need to relearn that
lesson the hard way. (Admittedly, this isn't quite *query* semantics,
which perhaps lessens the blast radius. But I think we're still going
to regret query_id_squash_values.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-03-25 03:30:59 | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |
| Previous Message | Sami Imseih | 2025-03-25 02:38:35 | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-03-25 03:01:52 | pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency |
| Previous Message | Andres Freund | 2025-03-25 02:52:19 | Re: AIO v2.5 |