Re: Minor cleanups in the SSL tests

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Minor cleanups in the SSL tests
Date: 2024-09-03 18:35:12
Message-ID: DF560F2E-A524-420E-B8C8-D0B4C1875F0A@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 17 May 2024, at 09:58, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 17 May 2024, at 07:57, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> On 16.05.24 23:27, Daniel Gustafsson wrote:
>>>> On 16 May 2024, at 11:43, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>>> You might want to run your patch through pgperltidy. The result doesn't look bad, but a bit different than what you had crafted.
>>> Ugh, I thought I had but clearly had forgotten. Fixed now.
>>>> append_conf() opens and closes the file for each call. It might be nice if it could accept a list. Or you can just pass the whole block as one string, like it was done for pg_ident.conf before.
>>> The attached v2 pass the whole block as a here-doc which seemed like the best
>>> option to retain readability of the config.
>>
>> Works for me.
>
> Thanks for review. Once the tree opens up for v18 I'll go ahead with this.

This has now been pushed after a little bit of editorializing and another
pgperltidy run.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-09-03 18:39:25 Re: optimizing pg_upgrade's once-in-each-database steps
Previous Message Matthias van de Meent 2024-09-03 17:59:30 Re: list of acknowledgments for PG17