Re: Minor cleanups in the SSL tests

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Minor cleanups in the SSL tests
Date: 2024-05-17 07:58:59
Message-ID: 01FE6E25-A522-4501-BD81-58515ADCA351@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 17 May 2024, at 07:57, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 16.05.24 23:27, Daniel Gustafsson wrote:
>>> On 16 May 2024, at 11:43, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>> You might want to run your patch through pgperltidy. The result doesn't look bad, but a bit different than what you had crafted.
>> Ugh, I thought I had but clearly had forgotten. Fixed now.
>>> append_conf() opens and closes the file for each call. It might be nice if it could accept a list. Or you can just pass the whole block as one string, like it was done for pg_ident.conf before.
>> The attached v2 pass the whole block as a here-doc which seemed like the best
>> option to retain readability of the config.
>
> Works for me.

Thanks for review. Once the tree opens up for v18 I'll go ahead with this.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2024-05-17 08:13:22 Re: avoid MERGE_ACTION keyword?
Previous Message Heikki Linnakangas 2024-05-17 07:32:54 Re: commitfest.postgresql.org is no longer fit for purpose