| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Minor cleanups in the SSL tests |
| Date: | 2024-05-17 05:57:38 |
| Message-ID: | 5e7ab50a-b1e8-4079-9c0c-4585374c73b1@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16.05.24 23:27, Daniel Gustafsson wrote:
>> On 16 May 2024, at 11:43, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
>> You might want to run your patch through pgperltidy. The result doesn't look bad, but a bit different than what you had crafted.
>
> Ugh, I thought I had but clearly had forgotten. Fixed now.
>
>> append_conf() opens and closes the file for each call. It might be nice if it could accept a list. Or you can just pass the whole block as one string, like it was done for pg_ident.conf before.
>
> The attached v2 pass the whole block as a here-doc which seemed like the best
> option to retain readability of the config.
Works for me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yasir | 2024-05-17 06:09:09 | Ignore Visual Studio's Temp Files While Working with PG on Windows |
| Previous Message | Peter Eisentraut | 2024-05-17 05:50:56 | Re: Why does pgindent's README say to download typedefs.list from the buildfarm? |