Re: Why does pgindent's README say to download typedefs.list from the buildfarm?

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Date: 2024-05-17 05:50:56
Message-ID: 7b8a5256-1414-4522-88e8-81b2bf8c0651@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 16.05.24 16:45, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> In these cases, I think for
>> NotificationHash
>> ResourceOwnerData
>> WalSyncMethod
>> we can just get rid of the typedef.
>
> I have no objection to dealing with NotificationHash as you have here.
>
>> ReadBuffersFlags shouldn't be an enum at all, because its values are
>> used as flag bits.
>
> Yeah, that was bothering me too, but I went for the minimum delta.
> I did think that a couple of integer macros would be a better idea,
> so +1 for what you did here.

I committed this, and Michael took care of WaitEventExtension, so we
should be all clear here.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-05-17 05:57:38 Re: Minor cleanups in the SSL tests
Previous Message Michael Paquier 2024-05-17 05:24:52 Re: Why does pgindent's README say to download typedefs.list from the buildfarm?