From: | Marat Bukharov <marat(dot)buharov(at)gmail(dot)com> |
---|---|
To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] Add min/max aggregate functions to BYTEA |
Date: | 2024-07-24 14:42:11 |
Message-ID: | CAPCEVGVi5A65V5chbdwyh9jtsFWuz1eUR__mkPbkHL3MJtpTzA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
V5 patch. I've added more tests with different bytea sizes
--
With best regards,
Marat Bukharov
чт, 4 июл. 2024 г. в 15:29, Aleksander Alekseev <aleksander(at)timescale(dot)com>:
>
> Hi Marat,
>
> > V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP
>
> Thanks for the patch.
>
> Please add it to the nearest open commitfest [1].
>
> ```
> +select min(v) from bytea_test_table;
> + min
> +------
> + \xaa
> +(1 row)
> +
> +select max(v) from bytea_test_table;
> + max
> +------
> + \xff
> +(1 row)
> ```
>
> If I understand correctly, all the v's are of the same size. If this
> is the case you should add more test cases.
>
> [1]: https://commitfest.postgresql.org/
>
> --
> Best regards,
> Aleksander Alekseev
Attachment | Content-Type | Size |
---|---|---|
v5-0001-add-bytea-agg-funcs.patch | text/x-patch | 8.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Marat Bukharov | 2024-07-24 14:47:01 | Re: [PATCH] Add min/max aggregate functions to BYTEA |
Previous Message | Andreas Karlsson | 2024-07-24 14:31:32 | Re: Convert sepgsql tests to TAP |