| From: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Marat Bukharov <marat(dot)buharov(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add min/max aggregate functions to BYTEA |
| Date: | 2024-08-02 09:20:04 |
| Message-ID: | 0B14B264-B120-454F-8F6E-BF36B23DC5A2@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 24 Jul 2024, at 17:42, Marat Bukharov <marat(dot)buharov(at)gmail(dot)com> wrote:
>
> V5 patch. I've added more tests with different bytea sizes
Hi Marat!
This looks like a nice feature to have.
I’ve took a look into the patch and have few suggestions:
0. Please write more descriptive commit message akin to [0]
1. Use oids from development range 8000-9999
2. Replace VARDATA_ANY\memcmp dance with a call to varstrfastcmp_c().
Thank you!
Best regards, Andrey Borodin.
[0] https://github.com/postgres/postgres/commit/a0f1fce80c03
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2024-08-02 09:31:06 | Re: Small refactoring around vacuum_open_relation |
| Previous Message | shveta malik | 2024-08-02 09:03:32 | Re: Logical Replication of sequences |