Re: [PATCH] Add min/max aggregate functions to BYTEA

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Marat Bukharov <marat(dot)buharov(at)gmail(dot)com>
Cc: Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Add min/max aggregate functions to BYTEA
Date: 2024-09-23 01:05:37
Message-ID: CAApHDvq-PaDK+NWcG4yhCFcQtvD8WzjzGO3WzJjM7GQREA5tYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 25 Jul 2024 at 02:42, Marat Bukharov <marat(dot)buharov(at)gmail(dot)com> wrote:
> V5 patch. I've added more tests with different bytea sizes

I just glanced over this patch. Are you still planning on working on
it? There's been no adjustments made since the last feedback you got
in early August.

Can you address Andrey's feedback on point #1?

Also, for bytea_larger() and bytea_smaller(), I suggest copying what's
been done in record_larger() and record_smaller() except use
byteacmp(). That'll remove all the duplicated code.

If you fix those up, I see no reason not to commit the patch.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2024-09-23 01:28:47 Re: Increase of maintenance_work_mem limit in 64-bit Windows
Previous Message jian he 2024-09-23 00:57:01 Re: Statistics Import and Export