| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Marat Bukharov <marat(dot)buharov(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] Add min/max aggregate functions to BYTEA |
| Date: | 2024-10-08 14:23:54 |
| Message-ID: | CAJ7c6TMQWB92tJ0YgAVuihXsJjtuK-b3oSz-ZDKjz5chv-TvLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> I just glanced over this patch. Are you still planning on working on
> it? There's been no adjustments made since the last feedback you got
> in early August.
>
> Can you address Andrey's feedback on point #1?
>
> Also, for bytea_larger() and bytea_smaller(), I suggest copying what's
> been done in record_larger() and record_smaller() except use
> byteacmp(). That'll remove all the duplicated code.
>
> If you fix those up, I see no reason not to commit the patch.
Since we haven't heard from Marat since July I decided to rebase the
patch and address the feedback received so far. PFA patch v6.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-min-and-max-aggregates-for-bytea-type.patch | application/octet-stream | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2024-10-08 14:26:50 | FOREIGN TABLE and IDENTITY columns |
| Previous Message | Anton A. Melnikov | 2024-10-08 14:16:55 | Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica. |