From: | Marat Bukharov <marat(dot)buharov(at)gmail(dot)com> |
---|---|
To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org, David Rowley <dgrowleyml(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: [PATCH] Add min/max aggregate functions to BYTEA |
Date: | 2024-10-08 18:12:22 |
Message-ID: | CAPCEVGXeJQY-=wwbp=2WMiYEAGmqQMYUejDhizeaZa7xv80oXA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thank you for the corrections. I was busy recently and did not follow
conversations in the mailing list. Sorry about that.
--
With best regards,
Marat Bukharov
вт, 8 окт. 2024 г. в 17:24, Aleksander Alekseev <aleksander(at)timescale(dot)com>:
>
> Hi,
>
> > I just glanced over this patch. Are you still planning on working on
> > it? There's been no adjustments made since the last feedback you got
> > in early August.
> >
> > Can you address Andrey's feedback on point #1?
> >
> > Also, for bytea_larger() and bytea_smaller(), I suggest copying what's
> > been done in record_larger() and record_smaller() except use
> > byteacmp(). That'll remove all the duplicated code.
> >
> > If you fix those up, I see no reason not to commit the patch.
>
> Since we haven't heard from Marat since July I decided to rebase the
> patch and address the feedback received so far. PFA patch v6.
>
> --
> Best regards,
> Aleksander Alekseev
From | Date | Subject | |
---|---|---|---|
Next Message | Alena Rybakina | 2024-10-08 18:29:30 | Re: On disable_cost |
Previous Message | Tom Lane | 2024-10-08 17:52:49 | Re: [PATCH] Add min/max aggregate functions to BYTEA |