Re: [PATCH] Add min/max aggregate functions to BYTEA

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Marat Bukharov <marat(dot)buharov(at)gmail(dot)com>
Subject: Re: [PATCH] Add min/max aggregate functions to BYTEA
Date: 2024-07-04 12:29:09
Message-ID: CAJ7c6TMLcsisvnCLDyfhcbeVvJeNQABM12+gYjqh4m6cKinN+A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Marat,

> V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP

Thanks for the patch.

Please add it to the nearest open commitfest [1].

```
+select min(v) from bytea_test_table;
+ min
+------
+ \xaa
+(1 row)
+
+select max(v) from bytea_test_table;
+ max
+------
+ \xff
+(1 row)
```

If I understand correctly, all the v's are of the same size. If this
is the case you should add more test cases.

[1]: https://commitfest.postgresql.org/

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Wienhold 2024-07-04 12:34:35 Re: Underscore in positional parameters?
Previous Message Jelte Fennema-Nio 2024-07-04 12:20:39 Re: Make query cancellation keys longer