Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

From: Ryo Kanbayashi <kanbayashi(dot)dev(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Add regression tests of ecpg command notice (error / warning)
Date: 2025-03-03 05:09:45
Message-ID: CANOn0ExSbtNEM6zO5oZzcwJ-QWLQ7Q9HqbL-kux+niKQ5fce9A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>On Mon, Mar 3, 2025 at 12:23 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> On 2025/03/01 19:45, Ryo Kanbayashi wrote:
> >> +program_help_ok('ecpg');
> >> +program_version_ok('ecpg');
> >> +program_options_handling_ok('ecpg');
> >> +command_fails(['ecpg'], 'ecpg without arguments fails');
> >>
> >> These checks seem unnecessary in 002 since they're already covered in 001.
> >
> > I reflected above.
>
> Thanks for updating the patch!
>
> I've made some minor fixes and cosmetic adjustments.
> The updated patch is attached.
>
> Unless there are any objections, I'll commit it.

Thanks for reviewing and adustments.
There is no objections :)

---
Great regards,
Ryo Kanbayashi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-03-03 05:23:51 Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible
Previous Message Jacob Brazeal 2025-03-03 05:06:18 Re: Accidental assignment instead of compare in GetOperatorFromCompareType?