| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Ryo Kanbayashi <kanbayashi(dot)dev(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Add regression tests of ecpg command notice (error / warning) |
| Date: | 2025-03-03 03:23:56 |
| Message-ID: | 716c896f-99c7-49c3-a4ec-90441448eeb2@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025/03/01 19:45, Ryo Kanbayashi wrote:
>> +program_help_ok('ecpg');
>> +program_version_ok('ecpg');
>> +program_options_handling_ok('ecpg');
>> +command_fails(['ecpg'], 'ecpg without arguments fails');
>>
>> These checks seem unnecessary in 002 since they're already covered in 001.
>
> I reflected above.
Thanks for updating the patch!
I've made some minor fixes and cosmetic adjustments.
The updated patch is attached.
Unless there are any objections, I'll commit it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-ecpg-Add-TAP-test-for-the-ecpg-command.patch | text/plain | 7.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-03-03 03:38:59 | Re: [Patch] add new parameter to pg_replication_origin_session_setup |
| Previous Message | Junwang Zhao | 2025-03-03 01:53:45 | Re: Make COPY format extendable: Extract COPY TO format implementations |