From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Ryo Kanbayashi <kanbayashi(dot)dev(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] Add regression tests of ecpg command notice (error / warning) |
Date: | 2025-03-04 06:01:56 |
Message-ID: | a3570706-5c4b-44cf-9c74-0756f41b9e13@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2025/03/03 14:09, Ryo Kanbayashi wrote:
>> On Mon, Mar 3, 2025 at 12:23 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> On 2025/03/01 19:45, Ryo Kanbayashi wrote:
>>>> +program_help_ok('ecpg');
>>>> +program_version_ok('ecpg');
>>>> +program_options_handling_ok('ecpg');
>>>> +command_fails(['ecpg'], 'ecpg without arguments fails');
>>>>
>>>> These checks seem unnecessary in 002 since they're already covered in 001.
>>>
>>> I reflected above.
>>
>> Thanks for updating the patch!
>>
>> I've made some minor fixes and cosmetic adjustments.
>> The updated patch is attached.
>>
>> Unless there are any objections, I'll commit it.
>
> Thanks for reviewing and adustments.
> There is no objections :)
I've pushed the patch. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2025-03-04 06:05:17 | Re: vacuumdb changes for stats import/export |
Previous Message | Pavel Stehule | 2025-03-04 05:34:14 | Re: proposal - plpgsql - support standard syntax for named arguments for cursors |