Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Ryo Kanbayashi <kanbayashi(dot)dev(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Add regression tests of ecpg command notice (error / warning)
Date: 2025-03-04 22:26:47
Message-ID: CAOYmi+ks8wO06Ymxduw2h_eQJ_D4_jHGeyMK0P=p5Q3psnEdMA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 3, 2025 at 10:02 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> I've pushed the patch. Thanks!

Hi all,

> +tests += {
> + 'name': 'ecpg',
> + 'sd': meson.current_source_dir(),
> + 'bd': meson.current_build_dir(),
> + 'tap': {
> + 'tests': [
> + 't/001_ecpg_err_warn_msg.pl',
> + 't/002_ecpg_err_warn_msg_informix.pl',
> + ],
> + 'deps': ecpg_exe,
> + },
> +}

My version of Meson is complaining about this use of 'deps':

../meson.build:3603: WARNING: Project targets '>=0.54' but uses
feature introduced in '0.60.0': list.<plus>. The right hand operand
was not a list.
Adding test "ecpg/001_ecpg_err_warn_msg"
...

ecpg_exe should perhaps be wrapped in a list for now? I.e.

- 'deps': ecpg_exe,
+ 'deps': [ecpg_exe],

Thanks,
--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-03-04 22:28:55 Re: scalability bottlenecks with (many) partitions (and more)
Previous Message Andres Freund 2025-03-04 22:25:56 Snapshot related assert failure on skink