| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Euler Taveira <euler(dot)taveira(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible |
| Date: | 2025-03-03 05:23:51 |
| Message-ID: | Z8U854O5RayMMgoc@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 28, 2025 at 12:40:13PM -0800, Jacob Champion wrote:
> v9 removes the first call, and moves the second (now only) call up and
> out of the if/else chain, just past client authentication. The SSL
> pre-auth tests have been removed.
I have put my eyes on 0001, and this version looks sensible here, just
tweaked a bit the comments after a closer lookup and adjusted a few
things, nothing huge..
/* Update app name to current GUC setting */
+ /* TODO: ask the list: maybe do this before setting STATE_UNDEFINED? */
if (application_name)
pgstat_report_appname(application_name);
This has always been set last and it's still the case in the patch, so
let's just remove that.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-pgstat-report-in-earlier-with-STATE_STARTING.patch | text/x-diff | 19.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-03-03 05:26:42 | Re: doc: Mention clock synchronization recommendation for hot_standby_feedback |
| Previous Message | Ryo Kanbayashi | 2025-03-03 05:09:45 | Re: [PATCH] Add regression tests of ecpg command notice (error / warning) |