Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Euler Taveira <euler(dot)taveira(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible
Date: 2025-02-28 20:40:13
Message-ID: CAOYmi+k=-ZdzfmaQwpRKodDHChoyNN-uxbD_G7zY_5cWz+yvhA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 14, 2025 at 5:34 PM Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> (But it doesn't
> seem like we're going to agree on this for now; in the meantime I'll
> prepare a version of the patch that only calls
> pgstat_bestart_security() once.)

v9 removes the first call, and moves the second (now only) call up and
out of the if/else chain, just past client authentication. The SSL
pre-auth tests have been removed.

Thanks!
--Jacob

Attachment Content-Type Size
since-v8.diff.txt text/plain 6.7 KB
v9-0001-pgstat-report-in-earlier-with-STATE_STARTING.patch application/octet-stream 18.9 KB
v9-0002-Report-external-auth-calls-as-wait-events.patch application/octet-stream 13.0 KB
v9-0003-squash-Report-external-auth-calls-as-wait-events.patch application/octet-stream 5.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-02-28 20:42:11 Re: vacuumdb changes for stats import/export
Previous Message Robert Haas 2025-02-28 20:37:49 Re: optimize file transfer in pg_upgrade