Re: Doc: fix track_io_timing description to mention pg_stat_io

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Hajime(dot)Matsunaga(at)nttdata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Masao(dot)Fujii(at)nttdata(dot)com
Subject: Re: Doc: fix track_io_timing description to mention pg_stat_io
Date: 2024-06-27 12:00:33
Message-ID: CAN55FZ0bHixmPP_FYSt4xYEJ+HLuTDofMWuS_ZojSF0+=YOrYw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, 27 Jun 2024 at 14:30, Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Thu, Jun 27, 2024 at 5:06 AM <Hajime(dot)Matsunaga(at)nttdata(dot)com> wrote:
> >
> > Hi,
> >
> > pg_stat_io has I/O statistics that are collected when track_io_timing is
> > enabled, but it is not mentioned in the description of track_io_timing.
> > I think it's better to add a description of pg_stat_io for easy reference.
> > What do you think?
>
> Seems quite reasonable to me given that track_wal_io_timing mentions
> pg_stat_wal. I noticed that the sentence about track_io_timing in the
> statistics collection configuration section [1] only mentions reads
> and writes -- perhaps it should also mention extends and fsyncs?

Both suggestions look good to me. If what you said will be
implemented, maybe track_wal_io_timing too should mention fsyncs?

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2024-06-27 12:01:18 Re: SQL/JSON query functions context_item doc entry and type requirement
Previous Message Peter Eisentraut 2024-06-27 11:57:37 Re: Should we document how column DEFAULT expressions work?