Re: Doc: fix track_io_timing description to mention pg_stat_io

From: <Hajime(dot)Matsunaga(at)nttdata(dot)com>
To: <byavuz81(at)gmail(dot)com>, <melanieplageman(at)gmail(dot)com>
Cc: <pgsql-hackers(at)lists(dot)postgresql(dot)org>, <Masao(dot)Fujii(at)nttdata(dot)com>
Subject: Re: Doc: fix track_io_timing description to mention pg_stat_io
Date: 2024-06-28 01:48:54
Message-ID: TYWPR01MB10742991B5A3EA39B081DA0D4A4D02@TYWPR01MB10742.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > On Thu, Jun 27, 2024 at 5:06 AM <Hajime(dot)Matsunaga(at)nttdata(dot)com> wrote:
> > >
> > > Hi,
> >
> > > pg_stat_io has I/O statistics that are collected when track_io_timing is
> > > enabled, but it is not mentioned in the description of track_io_timing.
> > > I think it's better to add a description of pg_stat_io for easy reference.
> > > What do you think?
> >
> > Seems quite reasonable to me given that track_wal_io_timing mentions
> > pg_stat_wal. I noticed that the sentence about track_io_timing in the
> > statistics collection configuration section [1] only mentions reads
> > and writes -- perhaps it should also mention extends and fsyncs?
>
> Both suggestions look good to me. If what you said will be
> implemented, maybe track_wal_io_timing too should mention fsyncs?

Thank you both for your positive comments.
I also think your suggestions seem good.

Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2024-06-28 03:04:40 stale comments about fastgetattr and heap_getattr
Previous Message Amit Langote 2024-06-28 00:49:45 Re: ON ERROR in json_query and the like