RE: Doc: fix track_io_timing description to mention pg_stat_io

From: <Hajime(dot)Matsunaga(at)nttdata(dot)com>
To: <byavuz81(at)gmail(dot)com>, <melanieplageman(at)gmail(dot)com>
Cc: <pgsql-hackers(at)lists(dot)postgresql(dot)org>, <Masao(dot)Fujii(at)nttdata(dot)com>
Subject: RE: Doc: fix track_io_timing description to mention pg_stat_io
Date: 2024-07-03 08:51:01
Message-ID: TYWPR01MB10742F153EFA7E84AECAB9600A4DD2@TYWPR01MB10742.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Sent: Thursday, June 27, 2024 9:01 PM
>
> Hi,
>
> On Thu, 27 Jun 2024 at 14:30, Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
> >
> > On Thu, Jun 27, 2024 at 5:06 AM <Hajime(dot)Matsunaga(at)nttdata(dot)com> wrote:
> > >
> > > Hi,
> > >
> > > pg_stat_io has I/O statistics that are collected when track_io_timing is
> > > enabled, but it is not mentioned in the description of track_io_timing.
> > > I think it's better to add a description of pg_stat_io for easy reference.
> > > What do you think?
> >
> > Seems quite reasonable to me given that track_wal_io_timing mentions
> > pg_stat_wal. I noticed that the sentence about track_io_timing in the
> > statistics collection configuration section [1] only mentions reads
> > and writes -- perhaps it should also mention extends and fsyncs?
>
> Both suggestions look good to me. If what you said will be
> implemented, maybe track_wal_io_timing too should mention fsyncs?

Thanks for the suggestions the other day.
I have created a patch that incorporates your suggestions.

Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation

Attachment Content-Type Size
v2-0001-Doc-fix-track_io_timing-description-to-mention-pg.patch application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2024-07-03 09:33:44 pg_wal_summary_contents() and pg_walsummary may return different results on the same WAL summary file
Previous Message Matthias van de Meent 2024-07-03 08:50:21 Re: Incorrect Assert in BufFileSize()?