Re: Doc: fix track_io_timing description to mention pg_stat_io

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Hajime(dot)Matsunaga(at)nttdata(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Masao(dot)Fujii(at)nttdata(dot)com
Subject: Re: Doc: fix track_io_timing description to mention pg_stat_io
Date: 2024-06-27 11:29:47
Message-ID: CAAKRu_are9R_1qxu38Fr0ENt3fij9xugdkzqauxNELSP7eMgwg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 27, 2024 at 5:06 AM <Hajime(dot)Matsunaga(at)nttdata(dot)com> wrote:
>
> Hi,
>
> pg_stat_io has I/O statistics that are collected when track_io_timing is
> enabled, but it is not mentioned in the description of track_io_timing.
> I think it's better to add a description of pg_stat_io for easy reference.
> What do you think?

Seems quite reasonable to me given that track_wal_io_timing mentions
pg_stat_wal. I noticed that the sentence about track_io_timing in the
statistics collection configuration section [1] only mentions reads
and writes -- perhaps it should also mention extends and fsyncs?

- Melanie

[1] https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-STATS-SETUP

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2024-06-27 11:48:37 Re: pgsql: Add more SQL/JSON constructor functions
Previous Message Aleksander Alekseev 2024-06-27 10:45:51 Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)