From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix] |
Date: | 2016-10-21 14:55:29 |
Message-ID: | CAM5-9D-081KaqiSCrtup4Xnf=8rrK+B7tsd0ehCs8r_Kg9ukRA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
I missed to add the check "destroy only if select2 has destroy property'.
in previous patch.
It was reproducible when I select access method of exclusion constraint
from combo box.
Please find attached patch and review.
On Sat, Oct 15, 2016 at 12:50 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, applied.
>
>
> On Friday, October 14, 2016, Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)
> com> wrote:
>
>> Hi
>>
>> While clicking on Select2 control, it tries to destroy the control and
>> thus it doesn't get this object sometimes and throws error.
>>
>> It should attempt to destroy the select2 object only if this object is
>> not undefined.
>> Adds proper check to handle the case.
>>
>> Please find minor patch and review.
>>
>> Thanks
>> Surinder Kumar
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
Attachment | Content-Type | Size |
---|---|---|
select2_control_destroy_issue_v2.patch | application/octet-stream | 497 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-10-21 15:00:26 | pgAdmin 4 commit: Ensure steps and schedules can be created in empty jo |
Previous Message | Dave Page | 2016-10-21 14:39:47 | Re: PATCH: To raise an error if background job fails to start (pgAdmin4) |