From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix] |
Date: | 2016-10-21 15:16:20 |
Message-ID: | CA+OCxoyHfYkb4Opt0F-66ei2DPr3jMPXuogxxzSVefjaWaOhzQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied.
On Fri, Oct 21, 2016 at 3:55 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> I missed to add the check "destroy only if select2 has destroy property'. in
> previous patch.
> It was reproducible when I select access method of exclusion constraint from
> combo box.
>
> Please find attached patch and review.
>
> On Sat, Oct 15, 2016 at 12:50 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Thanks, applied.
>>
>>
>> On Friday, October 14, 2016, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>
>>> Hi
>>>
>>> While clicking on Select2 control, it tries to destroy the control and
>>> thus it doesn't get this object sometimes and throws error.
>>>
>>> It should attempt to destroy the select2 object only if this object is
>>> not undefined.
>>> Adds proper check to handle the case.
>>>
>>> Please find minor patch and review.
>>>
>>> Thanks
>>> Surinder Kumar
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-10-21 15:22:53 | Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL |
Previous Message | Surinder Kumar | 2016-10-21 15:16:13 | Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL |