Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]
Date: 2016-10-14 19:20:43
Message-ID: CA+OCxoy7UoDxC+4-__fyuDs7efaqj480V+Gnkz_E6RSD57s+MA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Friday, October 14, 2016, Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
wrote:

> Hi
>
> While clicking on Select2 control, it tries to destroy the control and
> thus it doesn't get this object sometimes and throws error.
>
> It should attempt to destroy the select2 object only if this object is not
> undefined.
> Adds proper check to handle the case.
>
> Please find minor patch and review.
>
> Thanks
> Surinder Kumar
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-10-14 19:23:15 pgAdmin 4 commit: Properly quote names when renaming FTS dictionaries a
Previous Message Dave Page 2016-10-14 19:20:35 pgAdmin 4 commit: While clicking on Select2 control, it tries to destro