Re: PATCH: To raise an error if background job fails to start (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To raise an error if background job fails to start (pgAdmin4)
Date: 2016-10-21 14:39:47
Message-ID: CA+OCxoy4454WZbcwUj1jqjSVw6-VBFKh0hQu_QorhQ3wyjdeCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Oct 21, 2016 at 2:40 PM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue where it was not reporting error when it fails to
> starts & went into infinite loop recursion of popup when task is deleted
> from server(which is a transient issue).
> RM#1679

Thanks, applied.

> Note: There is still TODO in this RM which I have added in code, for which
> I'm not able find any resolution meanwhile please review this issue.

Yeah, I'm not entirely sure how to deal with that either.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-10-21 14:55:29 Re: [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]
Previous Message Dave Page 2016-10-21 14:35:09 pgAdmin 4 commit: Ensure we handle external processes that fail to star