From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
---|---|
To: | Platon Pronko <platon7pronko(at)gmail(dot)com> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: very long record lines in expanded psql output |
Date: | 2021-10-03 15:51:21 |
Message-ID: | CALNJ-vScipjoeAbUnV+z3jb1ZXAHUjJLipoTd4_2zh5tRt61zA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Oct 3, 2021 at 5:57 AM Platon Pronko <platon7pronko(at)gmail(dot)com>
wrote:
> On 2021-09-24 14:42, Andrew Dunstan wrote:
> >
> > On 9/24/21 12:49 AM, Platon Pronko wrote:
> >> On 2021-09-23 22:28, Andrew Dunstan wrote:
> >>>
> >>> 2. It would possibly be better to pass the relevant parts of the
> options
> >>> to print_aligned_vertical_line() rather than the whole options
> >>> structure. It feels odd to pass both that and opt_border.
> >>
> >> What do you think about doing it the other way around - passing only
> >> whole
> >> options structure? That way we will roll 4 parameters (opt_border,
> >> printTextFormat,
> >> and two xheader ones) into only one argument.
> >> This increases code coupling a bit, but I'm not sure if that's
> >> relevant here.
> >>
> >
> > Sure, as long as it doesn't result in duplicated computation.
>
> Hi!
>
> Please find attached the updated patch - with fixed braces and
> adjusted parameters to print_aligned_vertical_line().
>
> Best regards,
> Platon Pronko
Hi,
+ pg_log_error("\\pset: allowed xheader_width values are full
(default), column, page, or an number specifying exact width.");
an number specifying -> a number specifying
Cheers
From | Date | Subject | |
---|---|---|---|
Next Message | Jaime Casanova | 2021-10-03 16:20:21 | Re: 2021-09 Commitfest |
Previous Message | Tom Lane | 2021-10-03 13:48:14 | Re: 2021-09 Commitfest |