Re: very long record lines in expanded psql output

From: Platon Pronko <platon7pronko(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: very long record lines in expanded psql output
Date: 2021-10-03 12:57:33
Message-ID: 784205fd-ca87-68df-983c-b1c94ad9d6f0@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-09-24 14:42, Andrew Dunstan wrote:
>
> On 9/24/21 12:49 AM, Platon Pronko wrote:
>> On 2021-09-23 22:28, Andrew Dunstan wrote:
>>>
>>> 2. It would possibly be better to pass the relevant parts of the options
>>> to print_aligned_vertical_line() rather than the whole options
>>> structure. It feels odd to pass both that and opt_border.
>>
>> What do you think about doing it the other way around - passing only
>> whole
>> options structure? That way we will roll 4 parameters (opt_border,
>> printTextFormat,
>> and two xheader ones) into only one argument.
>> This increases code coupling a bit, but I'm not sure if that's
>> relevant here.
>>
>
> Sure, as long as it doesn't result in duplicated computation.

Hi!

Please find attached the updated patch - with fixed braces and
adjusted parameters to print_aligned_vertical_line().

Best regards,
Platon Pronko

Attachment Content-Type Size
fix-header-lines-in-expanded-output.patch text/x-patch 9.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenjing 2021-10-03 13:15:03 Re: [Proposal] Global temporary tables
Previous Message Andrew Dunstan 2021-10-03 12:22:57 Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set