| From: | Violet Cheng <vcheng(at)pivotal(dot)io> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, Sarah McAlear <smcalear(at)pivotal(dot)io>, Hao Wang <haowang(at)pivotal(dot)io>, Matthew Kleiman <mkleiman(at)pivotal(dot)io> |
| Subject: | Re: [pgAdmin4][patch] Fix feature tests failure |
| Date: | 2017-08-16 03:24:22 |
| Message-ID: | CAK588uRQH3sL3zVOr67LdjhU02PJwPfBYNQkU9GQcyFQ_30xNQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
Is there any update on this patch? Will it be committed soon?
Thanks,
Violet
On Thu, Aug 10, 2017 at 11:32 AM, Wenlin Zhang <wzhang(at)pivotal(dot)io> wrote:
> As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for
> those who would like to join) yesterday, these errors seem to occur only on
> her Ubuntu system. We have not replicated them on Mac. But they exist
> before this patch, also.
>
> We notice that copy/paste functionality is being tested in two feature
> tests, the query_tool_journey_test.py and copy_selected_query_results_feature_test.py.
> Perhaps we only need to test this behavior in one of the tests?
>
> We've confirmed that the patch is able to be applied against the current
> state of master without any changes after yesterday's commits.
>
> Thanks,
>
> Wenlin and Matt
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Violet Cheng | 2017-08-16 03:25:20 | Re: [pgadmin4][patch] Fix the style of the alert when connecting/disconnecting from a server |
| Previous Message | Shirley Wang | 2017-08-15 16:22:29 | Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor |