Re: [pgAdmin4][patch] Fix feature tests failure

On Wed, Aug 16, 2017 at 8:54 AM, Violet Cheng <vcheng(at)pivotal(dot)io> wrote:

> Hi,
>
> Is there any update on this patch? Will it be committed soon?
>
> Hi Violet,

I've committed the patch with some changes.
Removed one more occurrence of '_assert_not_clickable_because_out_of_view'
added later by Hao Wang in commit: 5141debae7e08d205e813dd9fc52b737a9f18184.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

> Thanks,
> Violet
>
> On Thu, Aug 10, 2017 at 11:32 AM, Wenlin Zhang <wzhang(at)pivotal(dot)io> wrote:
>
>> As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for
>> those who would like to join) yesterday, these errors seem to occur only on
>> her Ubuntu system. We have not replicated them on Mac. But they exist
>> before this patch, also.
>>
>> We notice that copy/paste functionality is being tested in two feature
>> tests, the query_tool_journey_test.py and copy_selected_query_results_feature_test.py.
>> Perhaps we only need to test this behavior in one of the tests?
>>
>> We've confirmed that the patch is able to be applied against the current
>> state of master without any changes after yesterday's commits.
>>
>> Thanks,
>>
>> Wenlin and Matt
>>
>
>