Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi

It seems like the keyboard shortcuts for commenting got mixed up.

Block commenting: CMD+Shift+/ should comment like /* */
Inline commenting: CMD + / should comment like --

As of now it's reversed.

Shirley

On Wed, Jul 26, 2017 at 7:51 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, applied. I also extended the code you added to ensure the labels
> for the Find/Replace options are now platform-correct.
>
> On Wed, Jul 26, 2017 at 10:29 AM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> Please find updated patch for new shortcut keys, I have tested it on all
>> three major platforms (macOS, Linux & Windows with Chrome, FF & IE11
>> Browsers).
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Jul 21, 2017 at 9:38 PM, Robert Eckhardt <reckhardt(at)pivotal(dot)io>
>> wrote:
>>
>>> Right - we lose the ability to uncomment multiple levels though, which
>>>> may also be useful.
>>>>
>>>
>>> Well yes.
>>>
>>> I would argue that simplicity trumps potential use. I'd also argue that
>>> attempting to maintain consistency across environments (IDEs, etc. ) is
>>> advantageous. This was the philosophy we were going with when enabling
>>> excel like behavior (also why I'm not fully happy with how it is today).
>>>
>>> -- Rob
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>