From: | Sarah McAlear <smcalear(at)pivotal(dot)io> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Cc: | Bing Xu <bxu(at)pivotal(dot)io> |
Subject: | Re: Code Folding in Code Mirror |
Date: | 2017-08-15 09:03:57 |
Message-ID: | CAGRPzo9FNe2Y9CZCO4YTBbL3=g9paG6_L7qy6xHqZQb8FwEn_A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Ok, it does work for the cases defined. We misunderstood how it works.
Still, could we enable this everywhere? What is the reason not to?
Thanks,
Bing & Sarah
On Tue, Aug 15, 2017 at 5:00 PM, Sarah McAlear <smcalear(at)pivotal(dot)io> wrote:
> Hi Hackers!
>
> We are working on unifying the CodeMirror stuff into one location. While
> looking at this we noticed that while there is logic for code folding, it
> doesn't seem to be working. Does it work for everyone else? We also started
> to wonder if there is a specific reason that code folding should be
> disabled anywhere? Would it not make more sense to have it look the same
> throughout pgAdmin? We understand that there are a few things that should
> be depending on the place in the app where it is used, such as 'editable'.
> Other than that, would it be acceptable to have the same configuration
> throughout?
>
> Thanks,
> Bing & Sarah
>
From | Date | Subject | |
---|---|---|---|
Next Message | Shirley Wang | 2017-08-15 16:22:29 | Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor |
Previous Message | Sarah McAlear | 2017-08-15 09:00:12 | Code Folding in Code Mirror |