From: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode |
Date: | 2017-12-14 08:55:06 |
Message-ID: | CAFiP3vzRk8DXjpFE57YWF3rFXfjX4rMNgNQBNUgWwqamGCoAfg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Murtuza,
Moving login related code from under decorator @app.before_first_request
to @app.before_request
will cause runtime user to login on each request. I think we need to find
some better way.
--
*Harshal Dhumal*
*Sr. Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Dec 14, 2017 at 2:02 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue where we were rendering Security URL's like
> change password, reset password in HTML templates while running in Desktop
> mode, we only register these security blueprints in Server mode hence it
> was failing with BuildError.
> RM#2952
>
> Also reverted RM#2922 because it not working as expected and causing
> runtime to render login screen.
>
>
> Thanks to Neel for helping me in testing the patch with latest runtime
> code.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-12-14 09:07:19 | Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger |
Previous Message | Khushboo Vashi | 2017-12-14 08:47:12 | Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger |