From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode |
Date: | 2017-12-14 16:00:08 |
Message-ID: | CAKKotZQrnW3p+sDw-0ti4_2tCVS+sx5QrJyPt6rBRp4hPAwyJQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Yes Harshal, you are right but due to RM#2922 changes now runtime is
rendering the Login page.
@Dave,
Please find updated patch, which will also fix the issue of user login on
each request in runtime.
RM#2952
RM#2922
--
Murtuza
On Thu, Dec 14, 2017 at 2:25 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi Murtuza,
>
> Moving login related code from under decorator @app.before_first_request
> to @app.before_request
> will cause runtime user to login on each request. I think we need to find
> some better way.
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Dec 14, 2017 at 2:02 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA patch to fix the issue where we were rendering Security URL's like
>> change password, reset password in HTML templates while running in Desktop
>> mode, we only register these security blueprints in Server mode hence it
>> was failing with BuildError.
>> RM#2952
>>
>> Also reverted RM#2922 because it not working as expected and causing
>> runtime to render login screen.
>>
>>
>> Thanks to Neel for helping me in testing the patch with latest runtime
>> code.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
Attachment | Content-Type | Size |
---|---|---|
RM_2952_v1.diff | text/plain | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2017-12-15 06:34:34 | Re: Enums printout - possible bug |
Previous Message | Murtuza Zabuawala | 2017-12-14 12:57:31 | [pgAdmin4][Patch]: Allow user to select error text |