Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger
Date: 2017-12-14 09:07:19
Message-ID: CAKKotZRXzroDrmLjJ-XDopk4GomGhHU+=6e5gQfm7-QssG7Kcw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Dec 14, 2017 at 2:17 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

>
>
> On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Yes, we can commit this code, It will add basic button navigation via Tab
>> key.
>>
>> I think we should hold till our final design gets ready.
>
​Adding 'tabindex' on button won't hurt in anyway and not become any kind
of hurdle in design.​

> I will keep the RM open until we add Tab navigation :)
>>
>>
>> On Wed, Dec 13, 2017 at 9:33 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi,
>>>
>>> On Wed, Dec 13, 2017 at 7:55 AM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA patch to add basic Tab key navigation in debugger window, where
>>>> user will be able to navigate buttons using Tab key.
>>>> RM#2897
>>>>
>>>> TODO:// Need to work on Debugger window Panel navigation.
>>>>
>>>
>>> Given our conversation this morning, do we still want to apply this at
>>> this time?
>>>
>>> (for the benefit of the list, Murtuza, Khushboo, Harshal and I were
>>> discussing a keyboard navigation strategy for the whole application).
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2017-12-14 11:56:29 Re: Enums printout - possible bug
Previous Message Harshal Dhumal 2017-12-14 08:55:06 Re: [pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode