Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false
Date: 2016-12-09 05:32:38
Message-ID: CAFOhELftFnNWYTOoTSXOZEjkNw1CMpmBZFnW=s__5sKGQUr-DQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the attached updated patch.

Thanks,
Khushboo

On Mon, Dec 5, 2016 at 11:09 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Friday, December 2, 2016, Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)
> com> wrote:
>
>> Hi.
>>
>> Please find the attached updated patch.
>>
>> Thanks,
>> Khushboo
>>
>> On Fri, Nov 25, 2016 at 7:12 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Fri, Nov 25, 2016 at 12:19 PM, Khushboo Vashi
>>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>> > Hi,
>>> >
>>> > Please find the attached updated patch.
>>>
>>> Please see the attached screenshot. It's still offering to let me
>>> connect to a database with datallowconn=false, or create objects in
>>> it.
>>>
>>> Fixed.
>>
>>
>>> It also doesn't display the properties or dashboard for it if I click
>>> on it - it just silently keeps displaying the properties/dashboard for
>>> the previous database.
>>>
>>> Fixed.
>>
>
> I'm still seeing graphs being generated when I've selected a template
> database with datallowconn = true. What is it showing me? I'm seeing
> transactions, tuple and block I/O, which I would not expect from a database
> that noone can connect to.
>
>
Fixed

> Thanks.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

Attachment Content-Type Size
RM_1801_ver4.patch text/x-patch 45.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2016-12-09 06:37:08 Re: [pgAdmin4][Patch]: RM #1994 Insert / update are truncating if column is character
Previous Message Dave Page 2016-12-08 10:37:17 Re: Patch: Fix typos of "vacuum" throughout