Re: Patch: Fix typos of "vacuum" throughout

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Anthony DeBarros <adebarros(at)gmail(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Fix typos of "vacuum" throughout
Date: 2016-12-08 10:37:17
Message-ID: CA+OCxoxxbLF6-89awuRuWi13p019rAjQeAnQ51tojXeU0k1BSA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, Dec 8, 2016 at 3:49 AM, Anthony DeBarros <adebarros(at)gmail(dot)com> wrote:
> Hi,
>
> I hope this is helpful to the team. I noticed that in the Parameter tab of
> the Create Table dialog that VACUUM was misspelled. Hey, it's not easy to
> remember if it's one "C" or two :-) So, I searched the codebase for all the
> misspellings of that particular word and corrected them in this patch.

Urgh - how did I miss that?

> It looks like Sublime Text also removed a couple of spaces at the end of
> lines; hope that's OK.

No problem.

> This is my first time submitting a patch to pgAdmin; thanks for considering.

May it be the first of many :-)

Thanks - patch applied!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2016-12-09 05:32:38 Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false
Previous Message Dave Page 2016-12-08 10:35:58 pgAdmin 4 commit: Fix various mis-spellings of VACUUM. Fixes #2005