Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false
Date: 2016-12-09 11:59:23
Message-ID: CA+OCxozqXWKmXZHhjD=m+X0T9iwMbF1k_Hxk=L0g0NUaR9Haqw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Dec 9, 2016 at 5:32 AM, Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Mon, Dec 5, 2016 at 11:09 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Friday, December 2, 2016, Khushboo Vashi
>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>> Hi.
>>>
>>> Please find the attached updated patch.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Fri, Nov 25, 2016 at 7:12 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>> Hi
>>>>
>>>> On Fri, Nov 25, 2016 at 12:19 PM, Khushboo Vashi
>>>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>> > Hi,
>>>> >
>>>> > Please find the attached updated patch.
>>>>
>>>> Please see the attached screenshot. It's still offering to let me
>>>> connect to a database with datallowconn=false, or create objects in
>>>> it.
>>>>
>>> Fixed.
>>>
>>>>
>>>> It also doesn't display the properties or dashboard for it if I click
>>>> on it - it just silently keeps displaying the properties/dashboard for
>>>> the previous database.
>>>>
>>> Fixed.
>>
>>
>> I'm still seeing graphs being generated when I've selected a template
>> database with datallowconn = true. What is it showing me? I'm seeing
>> transactions, tuple and block I/O, which I would not expect from a database
>> that noone can connect to.
>>
>
> Fixed
>
>>
>> Thanks.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-12-09 12:05:50 pgAdmin 4 commit: Don't cast data when saving in the edit grid, so erro
Previous Message Dave Page 2016-12-09 11:59:17 pgAdmin 4 commit: Treat databases with datallowconn=false appropriately