Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false
Date: 2016-12-05 17:39:27
Message-ID: CA+OCxowftivQtQ7FBBKZnZzrmSt7wqF4Jwff4WQm4jDonvOhQA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Friday, December 2, 2016, Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
wrote:

> Hi.
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, Nov 25, 2016 at 7:12 PM, Dave Page <dpage(at)pgadmin(dot)org
> <javascript:_e(%7B%7D,'cvml','dpage(at)pgadmin(dot)org');>> wrote:
>
>> Hi
>>
>> On Fri, Nov 25, 2016 at 12:19 PM, Khushboo Vashi
>> <khushboo(dot)vashi(at)enterprisedb(dot)com
>> <javascript:_e(%7B%7D,'cvml','khushboo(dot)vashi(at)enterprisedb(dot)com');>> wrote:
>> > Hi,
>> >
>> > Please find the attached updated patch.
>>
>> Please see the attached screenshot. It's still offering to let me
>> connect to a database with datallowconn=false, or create objects in
>> it.
>>
>> Fixed.
>
>
>> It also doesn't display the properties or dashboard for it if I click
>> on it - it just silently keeps displaying the properties/dashboard for
>> the previous database.
>>
>> Fixed.
>

I'm still seeing graphs being generated when I've selected a template
database with datallowconn = true. What is it showing me? I'm seeing
transactions, tuple and block I/O, which I would not expect from a database
that noone can connect to.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-12-05 17:39:28 Re: [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"
Previous Message Dave Page 2016-12-05 17:39:26 Re: [pgAdmin4][Patch]: Fixes #1986 - Properly handle non-ascii characters while loading & saving file