Re: ANALYZE ONLY

From: Michael Harris <harmic(at)gmail(dot)com>
To: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, postgres(at)jeltef(dot)nl, ilya(dot)evdokimov(at)tantorlabs(dot)com
Subject: Re: ANALYZE ONLY
Date: 2024-08-23 10:01:33
Message-ID: CADofcAUoDTFT0YfcEb=bfZyvMPUJ2cs+cTNdD9VMMjYLixkZEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks for the feedback Melih,

On Thu, 22 Aug 2024 at 21:26, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
> It seems like extended_relation_expr allows "tablename *" syntax too. That should be added in docs as well. (Same for VACUUM doc)

I had included it in the parameter description but had missed it from
the synopsis. I've fixed that now.

> We may also want to update the above note in ANALYZE doc.

Well spotted. I have updated that now.

> Tests don't seem right to me.
> I believe the above should be " PARTITION OF only_parted " instead of vacparted.
> It may better to insert into partitioned table (only_parted) instead of the partition (only_parted1);
>
> Also it may be a good idea to test VACUUM ONLY for inheritance tables the same way you test ANALYZE ONLY.

Well spotted again. I have fixed the incorrect table names and added
tests as suggested.

> Lastly, the patch includes an unrelated file (compile_flags.txt) and has whitespace errors when I apply it.

Oops! Fixed,

V2 of the patch is attached.

Cheers
Mike

Attachment Content-Type Size
v2-0001-Initial-implementation-of-the-ONLY-feature.patch application/octet-stream 14.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rafia Sabih 2024-08-23 10:02:37 Re: pgstattuple: fix free space calculation
Previous Message Xiaoran Wang 2024-08-23 10:00:47 Re: Improve pg_re_throw: check if sigjmp_buf is valid and report error