| From: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
|---|---|
| To: | Michael Harris <harmic(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, postgres(at)jeltef(dot)nl, ilya(dot)evdokimov(at)tantorlabs(dot)com |
| Subject: | Re: ANALYZE ONLY |
| Date: | 2024-08-29 11:30:27 |
| Message-ID: | CAGPVpCTDU-j7c81trGtqyjQTzZrNTAr60DxwdOUL6G_gg41_5A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
Michael Harris <harmic(at)gmail(dot)com>, 23 Ağu 2024 Cum, 13:01 tarihinde şunu
yazdı:
> V2 of the patch is attached.
>
Thanks for updating the patch. I have a few more minor feedbacks.
-ANALYZE [ ( <replaceable class="parameter">option</replaceable> [, ...] )
> ] [ <replaceable class="parameter">table_and_columns</replaceable> [, ...] ]
> +ANALYZE [ ( <replaceable class="parameter">option</replaceable> [, ...] )
> ] [ [ ONLY ] <replaceable class="parameter">table_and_columns</replaceable>
> [, ...] ]
I believe moving "[ ONLY ]" to the definitions of table_and_columns below,
as you did with "[ * ]", might be better to be consistent with other places
(see [1])
+ if ((options & VACOPT_VACUUM) && is_partitioned_table && ! i
> nclude_children)
There are also some issues with coding conventions in some places (e.g. the
space between "!" and "include_children" abode). I think running pgindent
would resolve such issue in most places.
[1] https://www.postgresql.org/docs/16/sql-createpublication.html
Regards,
--
Melih Mutlu
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-08-29 11:51:48 | Re: Make printtup a bit faster |
| Previous Message | Amit Kapila | 2024-08-29 11:12:50 | Re: Conflict Detection and Resolution |