| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
| Cc: | Michael Harris <harmic(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, postgres(at)jeltef(dot)nl, ilya(dot)evdokimov(at)tantorlabs(dot)com |
| Subject: | Re: ANALYZE ONLY |
| Date: | 2024-08-30 08:19:12 |
| Message-ID: | CACJufxHY9nOecqeJr8WsrvtHG+8BTOOXqpM7E4OuCCEcrBC7qg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 29, 2024 at 7:31 PM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
>
> Hi Michael,
>
> Michael Harris <harmic(at)gmail(dot)com>, 23 Ağu 2024 Cum, 13:01 tarihinde şunu yazdı:
>>
>> V2 of the patch is attached.
>
>
> Thanks for updating the patch. I have a few more minor feedbacks.
>
>> -ANALYZE [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] [ <replaceable class="parameter">table_and_columns</replaceable> [, ...] ]
>> +ANALYZE [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] [ [ ONLY ] <replaceable class="parameter">table_and_columns</replaceable> [, ...] ]
>
>
> I believe moving "[ ONLY ]" to the definitions of table_and_columns below, as you did with "[ * ]", might be better to be consistent with other places (see [1])
>
>> + if ((options & VACOPT_VACUUM) && is_partitioned_table && ! include_children)
>
>
I think you are right.
ANALYZE [ ( option [, ...] ) ] [ [ ONLY ] table_and_columns [, ...] ]
seems not explain commands like:
ANALYZE ONLY only_parted(a), ONLY only_parted(b);
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-08-30 08:24:19 | Re: Sequence Access Methods, round two |
| Previous Message | Anthonin Bonnefoy | 2024-08-30 07:37:03 | Re: Set query_id for query contained in utility statement |