| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT |
| Date: | 2024-11-19 00:02:15 |
| Message-ID: | CAD21AoCZPtDnsXTzOogry54KfBsdiKgECvJNqpduPXEnckyGkA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 18, 2024 at 3:41 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 19/11/2024 01:20, Masahiko Sawada wrote:
> > I realized that building test_radixtree.c with TEST_SHARED_RT fails
> > because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> > it's missing some header files to include. I've attached a patch to
> > include necessary header files in radixtree.h to make it
> > self-contained.
>
> +1. Please make sure the #includes are in alphabetical order.
Fixed.
>
> While we're at it, I noticed that lib/radixtree.h includes "postgres.h".
> That's against our usual convention.
Good catch. I've updated the patch accordingly.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Include-necessary-header-files-in-radixtree.h.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-11-19 00:17:25 | Re: Parallel heap vacuum |
| Previous Message | Heikki Linnakangas | 2024-11-18 23:41:30 | Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT |