Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT
Date: 2024-11-18 23:41:30
Message-ID: 671136a1-f15e-4caa-ac5d-0e05e29dd754@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19/11/2024 01:20, Masahiko Sawada wrote:
> I realized that building test_radixtree.c with TEST_SHARED_RT fails
> because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> it's missing some header files to include. I've attached a patch to
> include necessary header files in radixtree.h to make it
> self-contained.

+1. Please make sure the #includes are in alphabetical order.

While we're at it, I noticed that lib/radixtree.h includes "postgres.h".
That's against our usual convention.

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-11-19 00:02:15 Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT
Previous Message Heikki Linnakangas 2024-11-18 23:30:28 Re: Reduce TupleHashEntryData struct size by half